-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Hide Graph from UI when license/product tier not met #243559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
PR Cloud deployment started at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/585 |
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/774 |
38f7f84 to
540d4d1
Compare
540d4d1 to
b38e1c8
Compare
b38e1c8 to
8d5a8ab
Compare
|
Pinging @elastic/contextual-security-apps (Team:Cloud Security) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @albertoblaz |
PhilippeOberti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code related to the flyout folder LGTM! I'm a bit unsure about the code related to the product feature stuff. The implementation looks a bit odd to me, but I'm unfamiliar with how it's supposed to be done.
I'm reaching out to a couple of people offline and will get back to this asap
Thanks @PhilippeOberti! I was also a bit skeptical of the approach taken but I'm unfamiliar with gating features in Serverless. I noticed there's a pricing engine that is used in other places, but I sticked to the established pattern within Security Solution, according to these docs: Appreciated if you ping the right people to have a look at it :) |
Summary
Closes:
Should be merged after:
[Contextual Security] add support for new actor and target ECS schema fields #242376Add license tier (ESS/Self-Managed) and product tier (Serverless) checks to
useGraphPreviewto leverage thehasGraphRepresentationvalue that is used in multiple places to conditionally render the Graph in flyout and expandable flyout.Also leveraged
hasGraphRepresentationto check if feature is enabled via UI settings and simplified code.Screenshots
How to test
Self-Managed
yarn es snapshot --license basicyarn start --no-base-pathnode scripts/es_archiver load x-pack/solutions/security/test/cloud_security_posture_functional/es_archives/logs_gcp_audit --es-url http://elastic:changeme@localhost:9200 --kibana-url http://elastic:changeme@localhost:5601node scripts/es_archiver load x-pack/solutions/security/test/cloud_security_posture_functional/es_archives/security_alerts_modified_mappings --es-url http://elastic:changeme@localhost:9200 --kibana-url http://elastic:changeme@localhost:5601yarn es snapshot --license trialServerless
docker login -u <username> -p <password> docker.elastic.coand run Docker app. If it prompts for signing-in, use SSOyarn es serverless --projectType security --killkibana.dev.yml:yarn serverless-securitychmod +x ./load_serverless_fixtures.shfirst ofc)elastic_serverlessand passwordchangemekibana.dev.yml, comment out all lines underxpack.securitySolutionServerless.productTypesChecklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
No risks. Feature is not public yet.